Skip to content

[UR][OpenCL] Add missing mapping for CL_INVALID_KERNEL to UR OpenCL adapter and handle CL_INVALID_KERNEL_DEFINITION in urKernelCreate #18182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented Apr 24, 2025

Fixes oneapi-src/unified-runtime#2555

Also handles checking for CL_INVALID_KERNEL_DEFINITION inside urKernelCreate.

@martygrant
Copy link
Contributor Author

Failing test for Basic/sycl_2020_images/host_task_unsampled_image_write.cpp tracked here #18085

@martygrant martygrant marked this pull request as ready for review April 28, 2025 10:47
@martygrant martygrant requested a review from a team as a code owner April 28, 2025 10:47
@martygrant martygrant force-pushed the martin/openclErrorMapping branch from 714a122 to 3cb06cb Compare April 28, 2025 15:19
@martygrant martygrant requested a review from a team as a code owner April 28, 2025 15:19
@martygrant martygrant force-pushed the martin/openclErrorMapping branch from 3cb06cb to 8e04857 Compare April 28, 2025 16:49
@martygrant martygrant changed the title [UR][OpenCL] Add missing mapping for CL_INVALID_KERNEL and CL_INVALID_KERNEL_DEFINITION to UR OpenCL adapter [UR][OpenCL] Add missing mapping for CL_INVALID_KERNEL to UR OpenCL adapter and handle CL_INVALID_KERNEL_DEFINITION in urKernelCreate Apr 28, 2025
…d check for CL_INVALID_KERNEL_DEFINITION inside urKernelCreate.
@martygrant martygrant force-pushed the martin/openclErrorMapping branch from f30d2c2 to dde83bf Compare May 8, 2025 09:56
@martygrant
Copy link
Contributor Author

failed test tracked here #18349

@martygrant martygrant merged commit 6fe6915 into intel:sycl May 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenCL] Missing mapping from CL_INVALID_KERNEL to UR_RESULT_ERROR_INVALID_KERNEL
2 participants