-
Notifications
You must be signed in to change notification settings - Fork 769
[UR][OpenCL] Add missing mapping for CL_INVALID_KERNEL to UR OpenCL adapter and handle CL_INVALID_KERNEL_DEFINITION in urKernelCreate #18182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing test for Basic/sycl_2020_images/host_task_unsampled_image_write.cpp tracked here #18085 |
kbenzie
reviewed
Apr 28, 2025
714a122
to
3cb06cb
Compare
3cb06cb
to
8e04857
Compare
kbenzie
reviewed
Apr 29, 2025
2129b0c
to
8af6b15
Compare
…d check for CL_INVALID_KERNEL_DEFINITION inside urKernelCreate.
8af6b15
to
927a283
Compare
Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
f30d2c2
to
dde83bf
Compare
kbenzie
approved these changes
May 8, 2025
failed test tracked here #18349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oneapi-src/unified-runtime#2555
Also handles checking for CL_INVALID_KERNEL_DEFINITION inside urKernelCreate.